[GitHub] [mina-sshd] tomaswolf commented on a change in pull request #153: Do not rethrow, but always wrap in an IOException

[GitBox]

tomaswolf commented on a change in pull request #153:
URL: https://github.com/apache/mina-sshd/pull/153#discussion_r462598314



##########
File path: 
sshd-common/src/main/java/org/apache/sshd/common/future/AbstractSshFuture.java
##########
@@ -131,15 +125,6 @@ public boolean awaitUninterruptibly(long timeoutMillis) {
 
         if (Throwable.class.isAssignableFrom(actualType)) {
             Throwable t = GenericUtils.peelException((Throwable) value);
-            if (t != value) {
-                value = t;
-                actualType = value.getClass();
-            }
-
-            if (IOException.class.isAssignableFrom(actualType)) {
-                throw (IOException) value;
-            }
-

Review comment:
       Looks like this should be
   ```
   if (t != value) {
       value = t;
   }
   
   if (t instanceof SshException) {
       throw new SshException(((SshException) t).getDisconnectCode(), 
t.getMessage(), t);
   }
   ```
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org