[
https://issues.apache.org/jira/browse/DIRMINA-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187917#comment-17187917
]
Marcin L edited comment on DIRMINA-1130 at 8/31/20, 5:59 PM:
-------------------------------------------------------------
Are you sure? I can recreate this issue with a simple unit test. Can you test
attached patch on 2.1.X branch?
I'm getting on Windows
{noformat}
java.lang.UnsupportedOperationException: 'SO_SNDBUF' not supported
at
sun.nio.ch.ServerSocketChannelImpl.setOption(ServerSocketChannelImpl.java:132)
at
org.apache.mina.transport.socket.nio.NioSocketAcceptor.open(NioSocketAcceptor.java:255)
at
org.apache.mina.transport.socket.nio.NioSocketAcceptor.open(NioSocketAcceptor.java:52)
at
org.apache.mina.core.polling.AbstractPollingIoAcceptor$Acceptor.registerHandles(AbstractPollingIoAcceptor.java:591)
at
org.apache.mina.core.polling.AbstractPollingIoAcceptor$Acceptor.run(AbstractPollingIoAcceptor.java:460)
at
org.apache.mina.util.NamePreservingRunnable.run(NamePreservingRunnable.java:64)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
{noformat}
was (Author: the-thing):
Are you sure? I can recreate this issue with a simple unit test. Can you test
attached patch on 2.1.X branch?
> NIO socket acceptor should not set send buffer size on ServerSocket/Channel.
> ----------------------------------------------------------------------------
>
> Key: DIRMINA-1130
> URL: https://issues.apache.org/jira/browse/DIRMINA-1130
> Project: MINA
> Issue Type: Bug
> Components: Transport
> Affects Versions: 2.1.4
> Reporter: Marcin L
> Assignee: Jonathan Valliere
> Priority: Major
> Attachments: nio_socket_acceptor_test.patch
>
>
> NIO socket acceptor should not set *send buffer size* on ServerSocket/Channel.
> Setting *SO_SNDBUF* in NioSocketAcceptor as part of
> https://issues.apache.org/jira/projects/DIRMINA/issues/DIRMINA-1123 was
> unecessary.
> *SO_SNDBUF* can be set after socket listen() and connect() system calls.
> Setting send buffer size will most likely throw Exception in
> *NioSocketAcceptor* (hotspot JVM).
> See
> sun.nio.ch.ServerSocketChannelImpl#supportedOptions ->
> sun.nio.ch.ServerSocketChannelImpl.DefaultOptionsHolder#defaultOptions
> [http://hg.openjdk.java.net/jdk8/jdk8/jdk/file/tip/src/share/classes/sun/nio/ch/ServerSocketChannelImpl.java|http://example.com]
> [https://github.com/frohoff/jdk8u-jdk/blob/master/src/share/classes/sun/nio/ch/ServerSocketChannelImpl.java|http://example.com]
> Seems like only these options are supported and should be set before socket
> connection.
> SO_RCVBUF
> SO_REUSEADDR
> SO_REUSEPORT
> IP_TOS
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
