[
https://issues.apache.org/jira/browse/DIRMINA-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17188576#comment-17188576
]
Jonathan Valliere commented on DIRMINA-1130:
--------------------------------------------
Okay, I'm dumb. I thought the patch was patching something not just creating a
new class. Anyway, you're right. This does not work on Windows but it does
work on Linux and probably on BSD. I'm going to have to setup a BSD VM to try
it today. I'll probably just add a "is_windows" check before this is done.
> NIO socket acceptor should not set send buffer size on ServerSocket/Channel.
> ----------------------------------------------------------------------------
>
> Key: DIRMINA-1130
> URL: https://issues.apache.org/jira/browse/DIRMINA-1130
> Project: MINA
> Issue Type: Bug
> Components: Transport
> Affects Versions: 2.1.4
> Reporter: Marcin L
> Assignee: Jonathan Valliere
> Priority: Major
> Attachments: nio_socket_acceptor_test.patch
>
>
> NIO socket acceptor should not set *send buffer size* on ServerSocket/Channel.
> Setting *SO_SNDBUF* in NioSocketAcceptor as part of
> https://issues.apache.org/jira/projects/DIRMINA/issues/DIRMINA-1123 was
> unecessary.
> *SO_SNDBUF* can be set after socket listen() and connect() system calls.
> Setting send buffer size will most likely throw Exception in
> *NioSocketAcceptor* (hotspot JVM).
> See
> sun.nio.ch.ServerSocketChannelImpl#supportedOptions ->
> sun.nio.ch.ServerSocketChannelImpl.DefaultOptionsHolder#defaultOptions
> [http://hg.openjdk.java.net/jdk8/jdk8/jdk/file/tip/src/share/classes/sun/nio/ch/ServerSocketChannelImpl.java|http://example.com]
> [https://github.com/frohoff/jdk8u-jdk/blob/master/src/share/classes/sun/nio/ch/ServerSocketChannelImpl.java|http://example.com]
> Seems like only these options are supported and should be set before socket
> connection.
> SO_RCVBUF
> SO_REUSEADDR
> SO_REUSEPORT
> IP_TOS
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
