[ 
https://issues.apache.org/jira/browse/SSHD-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17195076#comment-17195076
 ] 

Lyor Goldstein commented on SSHD-1076:
--------------------------------------

Hi [~wolft] good to know that you managed, however you raised a legitimate 
concern. Please look at https://github.com/apache/mina-sshd/pull/165 and tell 
me what you think

> Make creation of the AuthFuture in ClientUserAuthService 
> configurable/overrideable
> ----------------------------------------------------------------------------------
>
>                 Key: SSHD-1076
>                 URL: https://issues.apache.org/jira/browse/SSHD-1076
>             Project: MINA SSHD
>          Issue Type: New Feature
>    Affects Versions: 2.5.1
>            Reporter: Thomas Wolf
>            Priority: Major
>
> I have a need to have my own {{AuthFuture}} implementation. With the current 
> implementation, the authentication timeout keeps running even while the 
> client is asking the user for input, such as for a passphrase for an 
> encrypted private key. If the user doesn't supply the information quickly 
> enough, the session gets closed behind his back when the timeout expires.
> So I need an {{AuthFuture}} that I can _pause_ while my client program is 
> requesting user input. I do have that actually, but currently I need to 
> subclass {{ClientUserAuthService}} (because 
> {{AbstractClientSession.getUserAuthService()}} has it as return type) _and_ 
> copy all its code because the creation of the {{AuthFuture}} is hard-coded as 
> {{new DefaultAuthFuture(...)}} in {{ClientUserAuthService.auth()}}.
> Factoring this out into a separate method {{protected AuthFuture 
> createAuthFuture(String serviceName, Object lock)}} would be one way (then I 
> could override without having to copy all the code), but maybe there is a 
> better way, such as a separately configurable AuthFutureFactory.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

Reply via email to