gnodet commented on a change in pull request #166:
URL: https://github.com/apache/mina-sshd/pull/166#discussion_r488594986
##########
File path:
sshd-core/src/main/java/org/apache/sshd/common/io/nio2/Nio2Session.java
##########
@@ -70,6 +71,8 @@
private final AtomicLong lastReadCycleStart = new AtomicLong();
private final AtomicLong writeCyclesCounter = new AtomicLong();
private final AtomicLong lastWriteCycleStart = new AtomicLong();
+ private final AtomicBoolean suspendRead = new AtomicBoolean(false);
+ private final AtomicReference<Runnable> readRunnable = new
AtomicReference<>(null);
Review comment:
In the current state, it's not needed imho, because this is only used
for "dumb" tcp connections, i.e. there's no graceful shutdown of the sessions,
the sockets are simply closed for forwarding sessions. I've just added some
javadoc to make it clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
