[
https://issues.apache.org/jira/browse/SSHD-1017?focusedWorklogId=504807&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-504807
]
ASF GitHub Bot logged work on SSHD-1017:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Oct/20 17:06
Start Date: 26/Oct/20 17:06
Worklog Time Spent: 10m
Work Description: lgoldstein commented on a change in pull request #176:
URL: https://github.com/apache/mina-sshd/pull/176#discussion_r512126291
##########
File path:
sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java
##########
@@ -1757,14 +1764,18 @@ protected void receiveNewKeys() throws Exception {
this, inCipher, outCipher, recommendedByteRekeyBlocks,
maxRekeyBlocks);
}
+ resetCounters();
+ lastKeyTimeValue.set(Instant.now());
+ firstKexPacketFollows = null;
+ }
+
+ protected void resetCounters() {
inBytesCount.set(0L);
outBytesCount.set(0L);
inPacketsCount.set(0L);
outPacketsCount.set(0L);
inBlocksCount.set(0L);
outBlocksCount.set(0L);
- lastKeyTimeValue.set(Instant.now());
- firstKexPacketFollows = null;
Review comment:
If it becomes too cumbersome you can use
`@SuppressWarnings("checkstyle:...the rule")` - I do not encourage it, but
sometimes it is better than the alternative
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 504807)
Time Spent: 50m (was: 40m)
> Add support for [email protected]
> ---------------------------------------------
>
> Key: SSHD-1017
> URL: https://issues.apache.org/jira/browse/SSHD-1017
> Project: MINA SSHD
> Issue Type: New Feature
> Reporter: Matt Sicker
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> See [protocol
> details|https://github.com/openbsd/src/blob/master/usr.bin/ssh/PROTOCOL.chacha20poly1305].
> * [RFC 7539|https://tools.ietf.org/html/rfc7539] describes the
> ChaCha20-Poly1305 algorithm.
> * [Dropbear
> implementation|https://github.com/mkj/dropbear/blob/master/chachapoly.c]
> * [OpenSSH
> implementation|https://github.com/openbsd/src/blob/master/usr.bin/ssh/cipher-chachapoly-libcrypto.c]
> The cipher is provided by Bouncycastle.
> As a bonus, this could potentially be adapted to propose an equivalent
> AES/GCM cipher encoding to how OpenSSH implements this ChaCha20-Poly1305
> cipher.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
