[
https://issues.apache.org/jira/browse/SSHD-1125?focusedWorklogId=558725&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-558725
]
ASF GitHub Bot logged work on SSHD-1125:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Feb/21 20:41
Start Date: 26/Feb/21 20:41
Worklog Time Spent: 10m
Work Description: tomaswolf commented on a change in pull request #181:
URL: https://github.com/apache/mina-sshd/pull/181#discussion_r583906259
##########
File path:
sshd-core/src/main/java/org/apache/sshd/server/forward/TcpipServerChannel.java
##########
@@ -215,10 +215,12 @@ protected OpenFuture doInit(Buffer buffer) {
}
if (streaming == Streaming.Async) {
+ int channelId = getId();
out = new BufferedIoOutputStream(
Review comment:
Hmmm. IIRC we had a number of attempts to deal with this in SSHD-1070.
Guillaume added code that tried essentially to achieve the same at a lower
level in #166. How does this interact with this new mechanism?
Also, we should double-check that we don't re-introduce SSHD-1069. (Though I
think that was specific to the forwarding case with Streaming.Async, i.e.,
exactly this code here, which is off by default.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 558725)
Time Spent: 1h 50m (was: 1h 40m)
> Provide a boundary on BufferedIoOutputStream writing to avoid memory overflow
> -----------------------------------------------------------------------------
>
> Key: SSHD-1125
> URL: https://issues.apache.org/jira/browse/SSHD-1125
> Project: MINA SSHD
> Issue Type: Bug
> Reporter: Lyor Goldstein
> Assignee: Lyor Goldstein
> Priority: Major
> Labels: memory
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Use an upper bound to the data pending in the {{BufferedIoOutputStream}}. The
> max data could be set to the max window size. Blocking until there is enough
> room should allow the client to read the data.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
