[
https://issues.apache.org/jira/browse/SSHD-1105?focusedWorklogId=570587&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-570587
]
ASF GitHub Bot logged work on SSHD-1105:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Mar/21 15:59
Start Date: 23/Mar/21 15:59
Worklog Time Spent: 10m
Work Description: tomaswolf commented on a change in pull request #183:
URL: https://github.com/apache/mina-sshd/pull/183#discussion_r599706196
##########
File path:
sshd-core/src/main/java/org/apache/sshd/client/auth/pubkey/UserAuthPublicKey.java
##########
@@ -56,6 +58,7 @@
protected Iterator<PublicKeyIdentity> keys;
protected PublicKeyIdentity current;
protected List<NamedFactory<Signature>> factories;
+ protected List<String> currentAlgorithms = new LinkedList<>();
Review comment:
This is a PR for SSHD-1105. That comparison will come in a later PR,
under the SSHD-1141 topic. I prefer my PRs to be on one topic only, and not mix
concerns.
I also won't add it to #184; while that one is about Jira issue SSHD-1141,
it it about the KexExtensionHandler. But once these two are in, I'll create
another PR for that comparison.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 570587)
Time Spent: 1h 20m (was: 1h 10m)
> Use all possible signatures for a public key type in public key authentication
> ------------------------------------------------------------------------------
>
> Key: SSHD-1105
> URL: https://issues.apache.org/jira/browse/SSHD-1105
> Project: MINA SSHD
> Issue Type: Improvement
> Affects Versions: 2.5.1
> Reporter: Lyor Goldstein
> Priority: Minor
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The current code iterates over the keys the user provided and then attempts
> to find a +single+ matching signature factory. However, for some key types
> (e.g., RSA) there is more than one possible signature - e.g., {{ssh-rsa,
> rsa-sha2-256, rsa-sha2-512}}. The code should try +all+ matching signature
> factories in the same +order+ as the user defined them.
> {code:java|title=Pseudo code}
> for (KeyPair kp : userKeys) {
> Collection<String> aliases = KeyUtils.getAllKeyTypeAliases(kp);
> for (SignatureFactory factory : userSignatures) {
> // NOTE: need to check how not to confuse ...-cert@openssh,com..
> key type aliases
> if (aliases.contains(factory.getName()) {
> tryPublicKeyAuth(factory, kp);
> }
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
