[
https://issues.apache.org/jira/browse/SSHD-1141?focusedWorklogId=575940&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-575940
]
ASF GitHub Bot logged work on SSHD-1141:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Apr/21 06:59
Start Date: 02/Apr/21 06:59
Worklog Time Spent: 10m
Work Description: lgoldstein commented on pull request #185:
URL: https://github.com/apache/mina-sshd/pull/185#issuecomment-812359568
Hi @tomaswolf , thanks for the great work. I do have one minor request -
before merging into `master` please run a **full** `mvn clean install` - this
is required due to the fact that during the build process the sources may be
(re-)formatted, which might change them. We need to make sure that if someone
pulls the code and compiles it, the `git status` command will not show any
changes to our committed files. In this case, there were 2 files that were not
properly formatted and they turned out when I was working on some issue and
built the code - I was surprised to see 2 extra files that I have not touched
marked as modified.
Again, no real harm - but let's try and avoid these potential pitfalls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 575940)
Time Spent: 4h 10m (was: 4h)
> Implement server-sig-algs
> -------------------------
>
> Key: SSHD-1141
> URL: https://issues.apache.org/jira/browse/SSHD-1141
> Project: MINA SSHD
> Issue Type: Improvement
> Reporter: Ian Wienand
> Assignee: Thomas Wolf
> Priority: Major
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> Mina sshd should implement server-sig-algs to report signature algorithms.
> Without the daemon sending server-sig-algs, clients fall back to ssh-rsa per
> RFC8332
> {quote}When authenticating with an RSA key against a server that does not
> implement the "server-sig-algs" extension, clients MAY default to an
> "ssh-rsa" signature to avoid authentication penalties.
> {quote}
> Some distributions, notably Fedora 33, have set default system policy to
> disallow insecure algorithms such as ssh-rsa. They thus can not find a
> suitable signature algorithm and fail to log in. Quite a high level of
> knowledge is required to override the default system cryptography policy, and
> it can be quite confusing because the user's ssh-key works in many other
> contexts (against openssh servers, etc.). For full details see discussion in
> SSHD-1118.
> For example, connecting to a recent openssh server I see something like
> {quote}debug1: kex_input_ext_info:
> server-sig-algs=<ssh-ed25519,[email protected],ssh-rsa,rsa-sha2-256,rsa-sha2-512,ssh-dss,ecdsa-sha2-nistp256,ecdsa-sha2-nistp384,ecdsa-sha2-nistp521,[email protected]>
> {quote}
> I believe that Mina SSHD does support these more secure signature algorithms,
> but because they aren't reported the client won't use them.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
