alex-sherwin commented on pull request #197: URL: https://github.com/apache/mina-sshd/pull/197#issuecomment-849821398
I have a pending PR I was going to open tonight that touches some of this too, and in mine I changed the `OpenSshCertificate` valid before/after variables to `Instant` as it feels like a better developer experience to interact with (in my opinion). I also found that there is some additional invalid encoding in the OpenSshCertificate code from the original PR that has gone unnoticed with the Critical Options/Extensions data. My upcoming PR was to include code which can easily generate signed OpenSshCertificates, but ended up making the aforementioned fixes/changes as well (preview: https://github.com/alex-sherwin/mina-sshd2/pull/1) @tomaswolf Would you prefer if I un-do my change of using `Instant` before submitting the final PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
