Hi,

I'm reviewing some parts of MINA (more specifically the SSL part), and I found that we default the read buffer to 2048 bytes, which seems a bit too small to me.

Typically, when handling TLS messages, we may have up to 16384 PDUs (max). If the buffer is too small, we havve to do some extra read up to the point we have received all the needed data.

At this point, I wonder if it wouldn't be a better idea to size the buffer to at least the max PDU size of a TLS message (ie 16384 bytes).

The drawback is that it may be more demanding on the GC, as we will allocate bigger buffers for each incoming message.


Incenditally I wonder if it wouldn't be a good idea to use a Thread Local Storage to keep the allocated buffer, and avoiding the allocation of such a buffer for every call (assuming we copy it if there is an executor in the chain).


Thoughts ?

--
Emmanuel Lécharny

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to