elecharny commented on issue #8:
URL: https://github.com/apache/mina-ftpserver/issues/8#issuecomment-1013046821
Indeed.
The problem is that when we instantiate the {{DefaultSslConfiguration}}, it
calls {{initContext()}} which calls:
{code:java}
SSLContext ctx = SSLContext.getInstance(enabledProtocol);
{code}
{{SSLContext.getInstance()} can only take one single String, the default
protocol to use. However, in the {{IODataConnectionFactory.createDataSocket()}}
uses the {{SSLSocket}} API, which can accept many protocols:
{code:java}
if (ssl.getEnabledProtocol() != null) {
ssoc.setEnabledProtocols(new String[] {
ssl.getEnabledProtocol() });
}
{code}
and here, there is a problem, because we only have one protocol set.
One solution could be to use an array of Protocols, but use teh first one as
the default.
It's a bit fishy though...
PS: I changed the default to TLSv1.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
