[ https://issues.apache.org/jira/browse/FTPSERVER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506236#comment-17506236 ]
Gary D. Gregory commented on FTPSERVER-506: ------------------------------------------- Hi All: Version 1.2.0 still breaks binary compatibility: The method {{SslConfiguration#getEnabledProtocols()}} must be a {{default}} method, it still is not. It can be implemented by simply creating an array of one element where the one element is returned by {{getEnabledProtocol()}} > Binary compatibility is broken in ftpserver-core 1.1.3, 1.2.0 vs 1.1.2 > ---------------------------------------------------------------------- > > Key: FTPSERVER-506 > URL: https://issues.apache.org/jira/browse/FTPSERVER-506 > Project: FtpServer > Issue Type: Bug > Components: Core > Reporter: Gary D. Gregory > Priority: Major > > Over at Apache Commons, when we update Commons Net from 1.1.2 to 1.1.3, we > get compile errors: > {noformat} > [INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @ > commons-net --- > [INFO] Changes detected - recompiling the module! > [INFO] Compiling 63 source files to > /home/runner/work/commons-net/commons-net/target/test-classes > [INFO] ------------------------------------------------------------- > Error: COMPILATION ERROR : > [INFO] ------------------------------------------------------------- > Error: > /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8] > org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract > and does not override abstract method getEnabledProtocols() in > org.apache.ftpserver.ssl.SslConfiguration > Error: > /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5] > method does not override or implement a method from a supertype > [INFO] 2 errors > [INFO] ------------------------------------------------------------- > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD FAILURE > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 20.310 s > [INFO] Finished at: 2022-03-04T02:17:14Z > [INFO] > ------------------------------------------------------------------------ > Error: Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile > (default-testCompile) on project commons-net: Compilation failure: > Compilation failure: > Error: > /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8] > org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract > and does not override abstract method getEnabledProtocols() in > org.apache.ftpserver.ssl.SslConfiguration > Error: > /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5] > method does not override or implement a method from a supertype > Error: -> [Help 1] > Error: > Error: To see the full stack trace of the errors, re-run Maven with the -e > switch. > Error: Re-run Maven using the -X switch to enable full debug logging. > Error: > Error: For more information about the errors and possible solutions, please > read the following articles: > Error: [Help 1] > http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException > Error: Process completed with exit code 1. > {noformat} > See PR Bump ftpserver-core from 1.1.2 to 1.1.3 Java CI #429: > https://github.com/apache/commons-net/runs/5416642453?check_suite_focus=true > Please don't break BC! That should be rule #1 IMO. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org