tomaswolf opened a new pull request, #35: URL: https://github.com/apache/mina/pull/35
Since Java 11, closing a ServerSocketChannel may release the socket only on the next select() call. If we try to register a new binding for an unbound socket before the next select, a BindException may be thrown. Ensure that there is a select() call between unbinding some sockets and binding new sockets. Mark the unbind futures as "done" only after that intervening select(). Test plan: - check out this PR - replace NioSocketAcceptor by the 2.0.23 version - run the SocketAcceptorTest on a JVM 11 (or newer). It should fail with a BindException. - git reset --hard - run the SocketAcceptorTest on a JVM 11 (or newer) again. It should pass. Note that if SocketAcceptorTest is run on a JVM 8, it will succeed in either case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
