robober opened a new issue, #268:
URL: https://github.com/apache/mina-sshd/issues/268
If heartbeat is waiting for a response from the server and the response did
not come within the allotted time, then we must kill the session because the
server is not responding, in which case the lack of response to waiting for a
response in `ClientConnectionService.sendHeartBeat` looks like wrong behavior.
Should we do something like
`
if (!replyReceived.await(toWait, TimeUnit.MILLISECONDS)) {
throw new TimeoutException("No response from server");
}
`
when waiting response on heartbeat request
Am I understanding heartbeat logic correctly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
