tomaswolf opened a new pull request, #315: URL: https://github.com/apache/mina-sshd/pull/315
Implement cancellation of futures such that cancelling a user-visible future also cancels the underlying internal operation. Since cancellations can be asynchronous, introduce the concept of a `CancelFuture` that can be used to wait until a cancellation has indeed been effected. Augment `Future.verify()` with additional optional `CancelOption` parameters so that client code can specify whether a time-out should cancel the future and its underlying operation. In particular, `DefaultConnectFuture.verify()` now by default does cancel the connection attempt on a time-out. This avoids leaking a socket if the low-level connection attempt succeeds after the high-level time-out has expired. Add a property to control a possibly connection time-out that might exist at the I/O library level. Add tests for connection time-outs and for cancelling a connection attempt, and verify that either no sessions are created, or if so, that they are being closed or already have been closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
