tomaswolf commented on code in PR #368: URL: https://github.com/apache/mina-sshd/pull/368#discussion_r1186728049
########## sshd-core/src/test/java/org/apache/sshd/client/keyverifier/KnownHostsServerKeyVerifierTest.java: ########## @@ -62,16 +46,33 @@ import org.junit.experimental.categories.Category; import org.junit.runners.MethodSorters; import org.mockito.Mockito; +import org.testcontainers.shaded.com.google.common.collect.HashMultimap; +import org.testcontainers.shaded.com.google.common.collect.Iterables; +import org.testcontainers.shaded.com.google.common.collect.Multimap; Review Comment: Please avoid dependencies on shaded things from org.testcontainers. I'd even avoid the Google collections altogether; It's not hard to write these tests with `Map<SsshdSocketAddress, List<KnownHostEntry>>`, especially using the pattern `map.computeIfAbsent(key, k -> new ArrayList<>()).add(value)`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
