[
https://issues.apache.org/jira/browse/DIRMINA-1122?focusedWorklogId=861078&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861078
]
ASF GitHub Bot logged work on DIRMINA-1122:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/May/23 20:39
Start Date: 08/May/23 20:39
Worklog Time Spent: 10m
Work Description: the-thing commented on PR #26:
URL: https://github.com/apache/mina/pull/26#issuecomment-1539019441
I applied the changes manually to 2.2.X. The peerAddress session attribute
has been removed, which was used to get the hostname for the SSL engine.
2.1.X - org.apache.mina.filter.ssl.SslHandler#init
```
InetSocketAddress peer = (InetSocketAddress)
session.getAttribute(SslFilter.PEER_ADDRESS);
// Create the SSL engine here
if (peer == null) {
sslEngine = sslFilter.sslContext.createSSLEngine();
} else {
sslEngine = sslFilter.sslContext.createSSLEngine(peer.getHostName(),
peer.getPort());
}
```
in 2.2.X - org.apache.mina.filter.ssl.SslFilter#createEngine
```
SSLEngine sslEngine = (addr != null) ?
sslContext.createSSLEngine(addr.getHostString(), addr.getPort()) :
sslContext.createSSLEngine();
```
#getHostString seems to be the problem as it is resolved IP address instead
the actual host.
Issue Time Tracking
-------------------
Worklog Id: (was: 861078)
Time Spent: 1h 40m (was: 1.5h)
> Add support for endpoint identification algorithm
> -------------------------------------------------
>
> Key: DIRMINA-1122
> URL: https://issues.apache.org/jira/browse/DIRMINA-1122
> Project: MINA
> Issue Type: Improvement
> Components: Filter, SSL
> Affects Versions: 2.0.22, 2.1.3
> Reporter: Marcin L
> Assignee: Jonathan Valliere
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments:
> DIRMINA-1122_-_endpoint_identification_algorithm_support.patch
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Support for endpoint identification algorithm was added in Java 1.7.
> Currently MINA supports providing single SNI name via
> org.apache.mina.filter.ssl.SslFilter#PEER_ADDRESS session attribute, but
> there is no way verifying it matches the certificate received.
> It would be nice if we could provide endpoint identification algorithm to
> SslFilter so certificate's common name or subject alternative names are
> verified.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
