tomaswolf commented on code in PR #347:
URL: https://github.com/apache/mina-sshd/pull/347#discussion_r1214522184
##########
docs/server-setup.md:
##########
@@ -45,8 +45,7 @@ implementation that you can use if you want. This
implementation will create a p
so it's mostly useful to launch the OS native shell. E.g.,
```java
-sshd.setShellFactory(new ProcessShellFactory(new String[] { "/bin/sh", "-i",
"-l" }));
-
+sshServer.setShellFactory(new ProcessShellFactory("/bin/sh -i -l", "-i", "-l"
));
```
Review Comment:
It's worse, but understandable if you look at existing uses. `command` is
supposed to be the full command as it was received, `elements` is supposed to
be the individual parts. The correct invocation is
```
new ProcessShellFactory("/bin/sh -i -l", "/bin/sh", "-i", "-l")
```
(This is from memory; I'm not at my development machine where I could easily
double-check this.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
