elecharny commented on PR #41: URL: https://github.com/apache/mina/pull/41#issuecomment-1784464949
@kllbzz reviewing the SslFilter code, I think I totally missed the part where the SslHandler is also initialized in the _SessionOpened_ function. Originally, it was done in the _onPostAdd_, but the code has been completely reviewed and replaced 2 years ago, and this is where the _onConnected_ part has been added and a call to it in the _sessionOpened_ method. I just checked and ran the test, and it seems that it works pretty well with the removal of the _onPostAdd_ initialization, but still, I think the proper removal has to be done in the _sessionOpened_ method. The rational is that teh _SslFilter_ can be added on the fly on an opened session, so removing the call to _onConnected_ in the _onPostAdd_ will defeat this feature. OTOH, if we remove the call to the _onConnect_ method in the _sessionOpened_ method, it should work as exepcted. Side note: 2 and a half year ago, we were initiating the handshake in the _onPostAdd_ method, and not in the _sessionOpened_ method, so I guess we introduced a regression there. Can you check with the removal of the _onConnected_ call in the _sessionOpened_ method? Thanks ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
