lgoldstein commented on PR #430: URL: https://github.com/apache/mina-sshd/pull/430#issuecomment-1844520166
Almost there - the only (minor) issue is assuming that the protocol property is either *null* or valid - as a matter of "safety" unless empty/blank strings have special semantics we treat them as "equivalent" to *null*. See my 2 comments - once you fix this I would be happy to merge this in. Good job on the whole... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
