jon-valliere commented on code in PR #44:
URL: https://github.com/apache/mina/pull/44#discussion_r1597475482
##########
mina-core/src/main/java/org/apache/mina/transport/socket/DefaultSocketSessionConfig.java:
##########
@@ -37,7 +37,7 @@ public class DefaultSocketSessionConfig extends
AbstractSocketSessionConfig {
private static final int DEFAULT_SO_LINGER = -1;
- private static final boolean DEFAULT_TCP_NO_DELAY = false;
+ private static final boolean DEFAULT_TCP_NO_DELAY = true; // Disable Nagle
algorithm by default
Review Comment:
Disabling Nagle by default may create context switching performance hits in
certain applications. Any situation where you may invoke more than one write
in sequence, receives performance boosts from the way the IO scheduler works in
TCP because it can produce MORE packets in a single go and does not have to be
woken up as often. The OS itself does not disable Nagle by default and I do
not think we should make this decision for the end user. As long as they can
configure it, I think the default should be `unset` (to allow the OS default to
apply). If other applications, built on MINA, want to configure a new default
then it is up to them. For SSHD or Apache Directory, if you want to disable
Nagle there, that is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
