tomaswolf commented on code in PR #507:
URL: https://github.com/apache/mina-sshd/pull/507#discussion_r1617833708
##########
sshd-core/src/main/java/org/apache/sshd/core/CoreModuleProperties.java:
##########
@@ -162,10 +162,21 @@ public final class CoreModuleProperties {
/**
* Key used to indicate that the heartbeat request is also expecting a
reply - time in <U>milliseconds</U> to wait
* for the reply. If non-positive then no reply is expected (nor
requested).
+ *
+ * @deprecated since 2.13.0, use {@link #HEARTBEAT_NO_REPLY_MAX} instead
*/
+ @Deprecated
public static final Property<Duration> HEARTBEAT_REPLY_WAIT
= Property.durationSec("heartbeat-reply-wait",
Duration.ofMinutes(5));
+ /**
+ * Key to set the maximum number of heartbeat messages to send without
having received a reply. If > 0, heartbeat
+ * messages are sent with a flag that requires the peer to reply. The
session will be killed if
+ * {@code HEARTBEAT_NO_REPLY_MAX} heartbeats have been sent without having
received a reply. If <= 0, heartbeat
+ * messages will be sent, but no reply is requested or expected, and the
client will not kill the session.
+ */
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
