tomaswolf commented on PR #511: URL: https://github.com/apache/mina-sshd/pull/511#issuecomment-2140908858
Thanks. The change is good, but now that this is fixed `DefaultIoServiceFactoryFactoryTest` hangs for MINA during disposal of the partially set up (with mocks) `MinaServiceFactory`. Previously it just skipped the non-existing class. Also, `BuiltinIoServiceFactoryFactoriesTest` should have a test that fails if one of the enum constants has a wrong class name. I.e., a test that would have uncovered the original problem (wrong string). I'll see if I can amend this commit to fix these test issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
