On 13.06.24 16:54 , Emmanuel Lécharny wrote:
My +1:
- checked the signature
- checked the N&L files
- built from source
One side note: on my new M3 mac, the
org.apache.sshd.common.cipher.ArcFourOpenSshTest test never finishes.
I will relaunch the tests to be sure, but it works just fine on my old
Intel mac.
(Java 11 on both computers)
I don't have an M3 mac so I cannot debug this test myself. The test
uses a docker container based on an old CentOS image to get an old
OpenSSH, then tests connections using the old outdated insecure and
definitely deprecated arcfour ciphers in combination with all MACs.
So there might be a problem with docker on M3 (unlikely as there is
at least one other test that also uses the same CentOS image), or
with the arcfour cipher on M3 or inside the container when run on
an M3 host.
We might consider removing the test, and just having a quick and
simple unit test that verifies that the block size of the arcfour
ciphers is 8. I had used that test to figure out what was going on
in Github issue 493 [1] but including it in our test suite may
have been overkill.
[1] https://github.com/apache/mina-sshd/issues/493
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
