tomaswolf commented on code in PR #565: URL: https://github.com/apache/mina-sshd/pull/565#discussion_r1695310491
########## sshd-core/src/main/java/org/apache/sshd/common/kex/extension/DefaultClientKexExtensionHandler.java: ########## @@ -133,4 +151,39 @@ protected void handleServerSignatureAlgorithms(Session session, Collection<Strin session.setSignatureFactories(clientAlgorithms); } } + + @Override + public void sendKexExtensions(Session session, KexPhase phase) throws Exception { Review Comment: This must send something only if the server had announced ext-info-s. Otherwise the client must not send any extensions. See the logic in the DefaultServerKexExtensionHandler. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org