tomaswolf commented on code in PR #579: URL: https://github.com/apache/mina-sshd/pull/579#discussion_r1709723638
########## pom.xml: ########## @@ -698,16 +698,6 @@ <artifactId>logback-classic</artifactId> <scope>test</scope> </dependency> - <dependency> - <groupId>junit</groupId> - <artifactId>junit</artifactId> - <scope>test</scope> - </dependency> - <dependency> - <groupId>org.mockito</groupId> - <artifactId>mockito-core</artifactId> - <scope>test</scope> - </dependency> Review Comment: I don't understand. The profile would have to be in the parent POM, but the property in the child POM. AFAIK that won't work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org