tomaswolf commented on issue #525: URL: https://github.com/apache/mina-sshd/issues/525#issuecomment-2289131557
Oh dear. This is wrong: https://github.com/apache/mina-sshd/blob/4f2ccf885292adde1d3a0d5f9abd9fb513b07688/sshd-common/src/main/java/org/apache/sshd/common/NamedFactory.java#L54 That's not "ignore unsupported", it's "include unsupported"! Gerrit calls it (quite naturally) with the value `true` [here](https://gerrit.googlesource.com/gerrit/+/refs/heads/master/java/com/google/gerrit/sshd/SshDaemon.java#483), but then it will never call `isSupported()`! The filter should be `ignoreUnsupported ? f.isSupported() : true` , and it should be called in `ClientBuilder` and `ServerBuilder` with the value `true`! Interestingly this bug has been in the code base since the method was introcued in 2015. :-( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
