tomaswolf commented on code in PR #653:
URL: https://github.com/apache/mina-sshd/pull/653#discussion_r1914484475
##########
sshd-core/src/main/java/org/apache/sshd/client/keyverifier/KnownHostsServerKeyVerifier.java:
##########
@@ -536,6 +537,16 @@ protected List<HostEntryPair> findKnownHostEntries(
return matches;
}
+ /**
+ * Invoked if any matching host entry has a 'revoked' marker
+ *
+ * @param clientSession The {@link ClientSession}
+ * @param remoteAddress The remote host address
+ * @param serverKey The presented server {@link PublicKey}
+ */
+ protected void handleRevokedKey(ClientSession clientSession, SocketAddress
remoteAddress, PublicKey serverKey) {
+ }
Review Comment:
Now PMD is unhappy about this empty block.
Either insert a comment `// By default do nothing`, or move the debug
logging from before the call into this body. The latter might make sense; if
someone overrides this, he can then decide whether to have that debug logging
(call super) or not (don't call super, do something else entirely).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
