tomaswolf commented on issue #656:
URL: https://github.com/apache/mina-sshd/issues/656#issuecomment-2592008466

   Thanks for reporting this. The intention was that you'd just read from the 
stream, and it'd reset its buffer itself. The `ChannelPipedInputStream` does 
call `ByteArrayBuffer.compact()` when more than 32kb have been read, or when 
all available data has been read.
   
   _However_: when all has been read, then `ByteArrayBuffer.compact()` does not 
resize the array but only resets the write and read positions. That's not good.
   
   This will need to be fixed in `ChannelPipedInputStream` so that the buffer 
array is cleared on EOF, and is indeed re-set to some small size if all 
currently available data has been read.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

Reply via email to