polo7 opened a new pull request, #79:
URL: https://github.com/apache/mina-ftpserver/pull/79
Hey there! :)
I see this place is already refactored in comparison with 'master' branch
and my changes are quite minor, but maybe you will find them useful. I propose
to realign if-conditions from `maskPassword &&
(request.trim().toUpperCase().startsWith("PASS "))` to
`(request.trim().toUpperCase().startsWith("PASS ")) && maskPassword` due to
usual use cases:
- maskPassword is mostly set to true
- request mostly _does not_ start with "PASS " during regular FTP-sessions
It will help us to hit the else-branch earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
