tomaswolf commented on issue #768:
URL: https://github.com/apache/mina-sshd/issues/768#issuecomment-3034750414

   First, regarding Artem's comment over there: the failure is not a connection 
failure, it's an authentication failure, and it's definitely not our business 
to close that session on an authentication failure. An authentication failure 
is not an SSH transport problem. From our point of view, client code has 
created the session, so client code shall close it.
   
   Second: yes, catching the `SshException` and closing the session on 
authentication failure is the way to go. Which is what we do in 
[`AbstractSshdSftpSessionFactory`](https://github.com/apache/mina-sshd/blob/f0608d7b3a0de703e409d0c90d9d3370b805e089/sshd-spring-sftp/src/main/java/org/apache/sshd/sftp/spring/integration/ApacheSshdSftpSessionFactory.java#L448),
 too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

Reply via email to