tomaswolf commented on PR #858: URL: https://github.com/apache/mina-sshd/pull/858#issuecomment-3655029319
There are a _lot_ more synchronized blocks and methods in Apache MINA sshd. I'm fine with replacing these two; I would object to replacing all uses of `synchronized` by re-entrant locks. If thread pinning is a problem, I think you could migrate to Java >= 24, which should have [JEP-491](https://openjdk.org/jeps/491) implemented: using `synchronized` together with virtual threads should not be a problem anymore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
