tomaswolf commented on code in PR #898:
URL: https://github.com/apache/mina-sshd/pull/898#discussion_r3252552724
##########
.asf.yaml:
##########
@@ -9,13 +9,26 @@ github:
- apache
features:
issues: true
- dependabot_alerts: true
+ dependabot_alerts: true
dependabot_updates: true
ghp_branch: gh-pages
ghp_path: /
+ rulesets:
+ - name: "Default Branch Protection"
+ type: branch
+ branches:
+ includes:
+ - "~DEFAULT_BRANCH"
+ - "release/*"
+ - "rel/*"
+ excludes: []
+ bypass_teams:
+ - root
+ restrict_deletion: true
+ restrict_force_push: true
Review Comment:
This just restricts _force_ pushes, right? Direct fast-forward pushes are
still possible?
##########
.asf.yaml:
##########
@@ -9,13 +9,26 @@ github:
- apache
features:
issues: true
- dependabot_alerts: true
+ dependabot_alerts: true
dependabot_updates: true
ghp_branch: gh-pages
ghp_path: /
+ rulesets:
+ - name: "Default Branch Protection"
+ type: branch
+ branches:
+ includes:
+ - "~DEFAULT_BRANCH"
+ - "release/*"
+ - "rel/*"
+ excludes: []
+ bypass_teams:
+ - root
+ restrict_deletion: true
Review Comment:
If someone creates a "rel" or "release" branch by mistake, how can I then
remove that?
##########
.asf.yaml:
##########
@@ -9,13 +9,26 @@ github:
- apache
features:
issues: true
- dependabot_alerts: true
+ dependabot_alerts: true
dependabot_updates: true
ghp_branch: gh-pages
ghp_path: /
+ rulesets:
+ - name: "Default Branch Protection"
+ type: branch
+ branches:
+ includes:
+ - "~DEFAULT_BRANCH"
+ - "release/*"
+ - "rel/*"
Review Comment:
We don't have `"release/*"` or `"rel/*"` branches. If we did branches for
releases (which will come once we publish 3.0.0), I think I'd rather name them
`"rel_*"`. Currently we just tag releases.
But in any case that can be done once we do have release branches. At this
point adding these two patterns is YAGNI.
##########
.asf.yaml:
##########
@@ -9,13 +9,26 @@ github:
- apache
features:
issues: true
- dependabot_alerts: true
+ dependabot_alerts: true
dependabot_updates: true
ghp_branch: gh-pages
ghp_path: /
+ rulesets:
+ - name: "Default Branch Protection"
+ type: branch
+ branches:
+ includes:
+ - "~DEFAULT_BRANCH"
+ - "release/*"
+ - "rel/*"
+ excludes: []
+ bypass_teams:
+ - root
Review Comment:
Who is this team "root"? Is there a team for PMC members? I'd like to have
at least _someone_ in the Apache MINA PMC to have the rights to bypass these
restrictions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
