elecharny commented on PR #52: URL: https://github.com/apache/mina/pull/52#issuecomment-4523310880
Hi @ppkarwasz, I have pushed the fluent API for the CompressionFilter class ([https://github.com/apache/mina/commit/94832ef543ded66fa2d8b7e9e2ca1f827d2e663b](https://github.com/apache/mina/commit/94832ef543ded66fa2d8b7e9e2ca1f827d2e663b)), easing the injection of some of the parameters. Two things: - I haven't changed the Zlib class because nobody is supposed to instanciate it but the Filter - I have changed two of the parameters to make them non-final in order to be able to create setters for them. Just let me know if that seems correct from your side. I will backport it to 2.1.X and 2.0.X. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
