tomaswolf commented on PR #910: URL: https://github.com/apache/mina-sshd/pull/910#issuecomment-5055949327
Can you please put the PR description minus the "Fixes #909" line into the commit message? Good commit messages are important, especially in OSS. For future contributors and maintainers it is very helpful if the commit messages explain the reasoning behind a change as it makes it much easier to figure out the history via `git blame`. If only the PR explains it, people would have to navigate away from git to find the PR first to learn why exactly a certain change was done. (OK, in this case there's also the inline comment, but still.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
