[
https://issues.apache.org/jira/browse/DIRMINA-1146?focusedWorklogId=1040661&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1040661
]
ASF GitHub Bot logged work on DIRMINA-1146:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Sep/26 07:29
Start Date: 10/Sep/26 07:29
Worklog Time Spent: 10m
Work Description: elecharny commented on PR #61:
URL: https://github.com/apache/mina/pull/61#issuecomment-5614818000
Actually, in the `IoHandler`, we should only deal with message that the
application has sent. TLS messages are technical, and they should not be
visible. So there is no reason to propagate them at all.
Two options here:
- either we don't generate a `messageSent` event when we are dealing with
TLS HS
- or we block them in the `SslFilter.messageSent()` (like what was done
somehow, but IMO wit a bit brutal solution, thus your proposal which solve the
original issue, but sadly has a side effect...)
I clearly don't like the first option because that would mean deep in the
`Processor` class where we fire this event, we have to know that TLS has been
set. I'd rather take the other road, may be by creating a specific
`HandshakeWriteRequest` which would inherit from `WriteRequest`, and checking
if we are dealing with such flavor of `WriteRequest` in the
`SslFilter.messageSent()` method...
Issue Time Tracking
-------------------
Worklog Id: (was: 1040661)
Time Spent: 1h 40m (was: 1.5h)
> TLS enabled session got disconnected when outbound messages add up to the
> value of maxscheduledwriterequests
> ------------------------------------------------------------------------------------------------------------
>
> Key: DIRMINA-1146
> URL: https://issues.apache.org/jira/browse/DIRMINA-1146
> Project: MINA
> Issue Type: Bug
> Reporter: Chily
> Assignee: Jonathan Valliere
> Priority: Blocker
> Fix For: 2.2.2
>
> Attachments: ConnectionEndPointIoHandler.java,
> EmDsectProtocolIoHandlare.java
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Slow Consumer Protection Feature does not work on TLS enabled session
> -> ioSession.getScheduledWriteMessages() never decreases in
> IoSessionResponder#send method
> internal.engine.session.maxscheduledwriterequests=10000
> Our TLS enabled session got disconneced when the outbound messages added up
> to 10000.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
