elecharny commented on PR #61: URL: https://github.com/apache/mina/pull/61#issuecomment-5614818000
Actually, in the `IoHandler`, we should only deal with message that the application has sent. TLS messages are technical, and they should not be visible. So there is no reason to propagate them at all. Two options here: - either we don't generate a `messageSent` event when we are dealing with TLS HS - or we block them in the `SslFilter.messageSent()` (like what was done somehow, but IMO wit a bit brutal solution, thus your proposal which solve the original issue, but sadly has a side effect...) I clearly don't like the first option because that would mean deep in the `Processor` class where we fire this event, we have to know that TLS has been set. I'd rather take the other road, may be by creating a specific `HandshakeWriteRequest` which would inherit from `WriteRequest`, and checking if we are dealing with such flavor of `WriteRequest` in the `SslFilter.messageSent()` method... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
