[
https://issues.apache.org/jira/browse/DIRMINA-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emmanuel Lécharny updated DIRMINA-1201:
---------------------------------------
Description:
When we add some logs in _AbstractPollingIoProcessor_, we get some failure in
the _MdcInjectionFilterTest_ class.
For instance, adding that log:
{code:java}
public final void remove(S session) {
LOG.debug( "Session {} has to be removed", session );
scheduleRemove(session);
startupProcessor();
}
{code}
make the _MdcInjectionFilterTest.testOnlyRemoteAddress_ test to fail:
{code:java}
java.lang.AssertionError: MDC[remoteAddress] not set for [Session (0x00000019:
nio socket, client, /127.0.0.1:61103 => localhost/127.0.0.1:61101) has to be
removed]
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.assertTrue(Assert.java:42)
at org.junit.Assert.assertNotNull(Assert.java:713)
at
org.apache.mina.filter.logging.MdcInjectionFilterTest.testOnlyRemoteAddress(MdcInjectionFilterTest.java:256)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at
org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:93)
at
org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:40)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:530)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:758)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:453)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:211)
{code}
The test is looping on the _LoggingEvents_ and at some point the following
assert fails:
{code:java}
...
for (MdcInjectionFilter.MdcKey mdcKey : MdcInjectionFilter.MdcKey.values()) {
String key = mdcKey.name();
Object value = event.getMDC(key);
if (mdcKey == MdcInjectionFilter.MdcKey.remoteAddress){
assertNotNull("MDC[remoteAddress] not set for [" + event.getMessage() +
"]", value);
} else {
...
{code}
The _value_ is null, most certainly because we don't store the remote address
when a session is removed.
was:
When we add some logs in `AbstractPollingIoProcessor`, we get some failure in
the `MdcInjectionFilterTest`.
For instance, adding that log:
```
/**
* {@inheritDoc}
*/
@Override
public final void remove(S session) {
LOG.debug( "Session {} has to be removed", session );
scheduleRemove(session);
startupProcessor();
}
```
make the `MdcInjectionFilterTest.testOnlyRemoteAddress` test to fail:
```
java.lang.AssertionError: MDC[remoteAddress] not set for [Session (0x00000019:
nio socket, client, /127.0.0.1:61103 => localhost/127.0.0.1:61101) has to be
removed]
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.assertTrue(Assert.java:42)
at org.junit.Assert.assertNotNull(Assert.java:713)
at
org.apache.mina.filter.logging.MdcInjectionFilterTest.testOnlyRemoteAddress(MdcInjectionFilterTest.java:256)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at
org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:93)
at
org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:40)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:530)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:758)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:453)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:211)
```
The test is looping on the `LoggingEvents` and at some point the following
assert fails:
```
...
for (MdcInjectionFilter.MdcKey mdcKey :
MdcInjectionFilter.MdcKey.values()) {
String key = mdcKey.name();
Object value = event.getMDC(key);
if (mdcKey == MdcInjectionFilter.MdcKey.remoteAddress) {
assertNotNull("MDC[remoteAddress] not set for [" +
event.getMessage() + "]", value);
} else {
...
```
The `value` is null, most certainly because we don't store the remote address
when a session is removed.
> Adding logs in AbstractPollingIoProcessor break a MDC test
> ----------------------------------------------------------
>
> Key: DIRMINA-1201
> URL: https://issues.apache.org/jira/browse/DIRMINA-1201
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.2.9, 2.1.15, 2.0.31
> Reporter: Emmanuel Lécharny
> Priority: Minor
> Fix For: 2.2.10
>
>
> When we add some logs in _AbstractPollingIoProcessor_, we get some failure in
> the _MdcInjectionFilterTest_ class.
> For instance, adding that log:
> {code:java}
> public final void remove(S session) {
> LOG.debug( "Session {} has to be removed", session );
> scheduleRemove(session);
> startupProcessor();
> }
> {code}
> make the _MdcInjectionFilterTest.testOnlyRemoteAddress_ test to fail:
> {code:java}
> java.lang.AssertionError: MDC[remoteAddress] not set for [Session
> (0x00000019: nio socket, client, /127.0.0.1:61103 =>
> localhost/127.0.0.1:61101) has to be removed]
> at org.junit.Assert.fail(Assert.java:89)
> at org.junit.Assert.assertTrue(Assert.java:42)
> at org.junit.Assert.assertNotNull(Assert.java:713)
> at
> org.apache.mina.filter.logging.MdcInjectionFilterTest.testOnlyRemoteAddress(MdcInjectionFilterTest.java:256)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at
> org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:93)
> at
> org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:40)
> at
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:530)
> at
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:758)
> at
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:453)
> at
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:211)
> {code}
> The test is looping on the _LoggingEvents_ and at some point the following
> assert fails:
> {code:java}
> ...
> for (MdcInjectionFilter.MdcKey mdcKey : MdcInjectionFilter.MdcKey.values()) {
> String key = mdcKey.name();
> Object value = event.getMDC(key);
> if (mdcKey == MdcInjectionFilter.MdcKey.remoteAddress){
> assertNotNull("MDC[remoteAddress] not set for [" + event.getMessage()
> + "]", value);
> } else {
> ...
> {code}
> The _value_ is null, most certainly because we don't store the remote address
> when a session is removed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
