Copilot commented on code in PR #930:
URL: https://github.com/apache/mina-sshd/pull/930#discussion_r4277795612
##########
sshd-core/src/main/java/org/apache/sshd/client/session/ClientConnectionService.java:
##########
@@ -122,6 +122,9 @@ public void start() {
@Override
protected synchronized ScheduledFuture<?> startHeartBeat() {
+ heartbeatRequest =
CoreModuleProperties.HEARTBEAT_REQUEST.getRequired(this);
Review Comment:
Optional: extend `testPerSessionHeartbeatConfiguration` to set a distinct
per-session `HEARTBEAT_REQUEST` before authentication and assert that the
server receives that request name. The test currently sets only the interval
and no-reply limit, and its handler ignores the request name, so it would still
pass if this refresh were removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
