To clarify, the 'distribution' module creates the tar ball with the
following configuration:
<!-- Copy sources into '/src' -->
<fileSet>
<directory>..</directory>
<outputDirectory>src</outputDirectory>
which move the sources in the 'src' subdirectory. It should probably be
change to '.'
Also it keeps the NOTICE files at the root:
<fileSet>
<directory>..</directory>
<outputDirectory></outputDirectory>
<includes>
<include>README*</include>
<include>LICENSE*</include>
<include>NOTICE*</include>
</includes>
</fileSet>
Those files are excluded from the src distribution repository:
<fileSet>
<directory>..</directory>
<outputDirectory>src</outputDirectory>
<includes>
<include>**/*</include>
</includes>
<excludes>
<exclude>KEYS</exclude>
<exclude>LICENSE*.txt</exclude>
<exclude>NOTICE.txt</exclude>
*except* the NOTICE-bin.txt. That has to be added as an exclusion.
Last, not least, the src package does not contain the distribution
module, which defeat the main goal: anyone should be able to build MINA
from the distributed packages (and yes, it does the job) except that we
can't create a newer tar ball because we don't include the distribution
module... That should probably be fixed.
On 15/10/2026 08:14, Emmanuel Lécharny wrote:
Minor findings: the source archive also contains a src/target
folder with contents. Probably that shouldn't be there?
Indeed. I'll check.
NOTICE-bin.txt exists twice in the archive, once at the root
and once inside the src folder.
And this src directory simply should not exist.
What we expect in the src tarball is the exact same strcuture than what
you get when cloning the repo: you are supposed to launch 'mvn clean
install' in the untarred package, when you should now move to src to do
that.
I'll check that for the next release.
Thanks!
--
------------------------
Emmanuel Lécharny
[email protected]
[email protected]
------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
