Hi Justin Thanks for the inputs and suggestions!
For the three issues you mentioned, I can share some inputs here 1. We usually conduct two votes for each release, one is call for release a new version (to see if dev are ok to release a new version given the milestone achieved, or there is any issue we missed that needs to be addressed before a new release), and this is the current vote thread. After this vote passes, we will have the second vote that includes the release candidate and all artifacts prepared for the dev to double check and vote again to make sure all the release materials are correct. If this is not the usual way that other projects manage the release, we could change it and follow the conventions from other projects, please let us know. 2. The missing download links from https://mnemonic.apache.org/downloads/ is a bug. I believe we have the 0.14.0 release download link added to the website already(https://github.com/apache/mnemonic-site), but I don't think the code change was reflected. We will have our dev to double check and make sure the website is synced. 0.15.0 release download link will be added to the site after the release is done and the code is uploaded to release repo. 3. Thanks for pointing out the compiled code in the 0.14.0 release. Our release candidate was prepared with a release script and I think we need to modify it to remove compiled code from the release candidate, we will fix it in this release. I will update my vote from +1 to -1 due to the issues and suggestions mentioned above. I think we need to address those in our 0.15.0 release which are yet to be done. Thanks again and we will update soon! Yanhui On Tue, Jun 15, 2021 at 10:47 PM Justin Mclean <[email protected]> wrote: > Hi, > > I also checked you 0.14 release and noticed that it contained compiled > code (gradle.jar file). I'm not on your PMC, but I suggest you reviews this > as compiled code is generally not allowed in the source release. There are > a number of ways around this issue, the simplest being to not include it in > the release artificial but leave it in version control or create a > convenience binary operate to the source release that consists of source > release and gradle wrapper. > > Kind Regards, > Justin >
