Yes, I will clean up according to item 1 & 2, Sorry for that, and also remove the developer info from pom.xml, Regarding the <inceptionYear>, should we set it as "The year of the project's inception" or "The year of the Apache project's inception" ? Thanks.
On 5/5/2016 7:27 AM, Patrick Hunt wrote: > Looks pretty good, a few issues: > > 1) missed some cleanup before the build? This is in the archive: > > $ ls allocator-services/service-dist/ > nvml-vmem-service-0.1.0-incubating-SNAPSHOT.jar > pmalloc-service-0.1.0-incubating-SNAPSHOT.jar > nvml-vmem-service-0.1.0-incubating.jar pmalloc-service-0.1.0-incubating.jar > nvml-vmem-service-0.1.1-incubating-SNAPSHOT.jar > pmalloc-service-0.1.1-incubating-SNAPSHOT.jar > nvml-vmem-service-0.1.1-incubating.jar pmalloc-service-0.1.1-incubating.jar > > did you mean to include the build and dist directories? > > $ ls ./allocator-services/nvml-vmem-service/src/main/native > CMakeLists.txt > LICENSE > build/ > common.c > common.h > config.h.in > dist/ > org_apache_mnemonic_service_allocatorservice_internal_VMemServiceImpl.c > org_apache_mnemonic_service_allocatorservice_internal_VMemServiceImpl.h > > 2) pom has a few items, needs to be reviewed: > > name should include Apache Mnemonic > developers section - not sure on this one, perhaps best to leave it > out? donno, perhaps check what other projects do... > inceptionYear seems wrong? > > Patrick > > On Wed, May 4, 2016 at 10:46 PM, Gary <ga...@apache.org> wrote: >> Hi all, >> >> This is a call for a discussion releasing Apache Mnemonic 0.1.1-incubating, >> release candidate 1. This >> is the first release of Mnemonic. >> >> The source tarball, including signatures, digests, etc. can be found at: >> https://dist.apache.org/repos/dist/dev/incubator/mnemonic/0.1.1-incubating-rc1/src/ >> >> The tag to be voted upon is v0.1.1-incubating: >> https://git-wip-us.apache.org/repos/asf?p=incubator-mnemonic.git;a=shortlog;h=refs/tags/v0.1.1-incubating >> >> The release hash is 8b26f1480bd4d3fd9ced65f6598d5fa1378015ad: >> https://git-wip-us.apache.org/repos/asf?p=incubator-mnemonic.git;a=commit;h=8b26f1480bd4d3fd9ced65f6598d5fa1378015ad >> >> Release artifacts are signed with the following key: >> https://people.apache.org/keys/committer/garyw.asc >> >> KEYS file available: >> https://dist.apache.org/repos/dist/dev/incubator/mnemonic/KEYS >> >> 38 issues were closed/resolved for this release: >> https://issues.apache.org/jira/browse/MNEMONIC >> >> Thanks, >> Gary >> >>
signature.asc
Description: OpenPGP digital signature
