[ 
https://issues.apache.org/jira/browse/MNEMONIC-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15812421#comment-15812421
 ] 

Wang, Gang commented on MNEMONIC-180:
-------------------------------------

Yes, It is definitively a bug, Thanks you found it.

> Missing throw for NoSuchElementException();
> -------------------------------------------
>
>                 Key: MNEMONIC-180
>                 URL: https://issues.apache.org/jira/browse/MNEMONIC-180
>             Project: Mnemonic
>          Issue Type: Bug
>            Reporter: Jaechang Nam
>            Priority: Trivial
>
> In recent snapshot from Github, it seems there is an exception (new 
> NoSuchElementException) that is not thrown. 
> (mnemonic-collections/src/main/java/org/apache/mnemonic/collections/DurableSinglyLinkedList.java)
> {code}
> 162     @Override
> 163     public E next() {
> 164       if (null == next) {
> 165         new NoSuchElementException();
> 166       }
> 167       E ret = next.getItem();
> 168       next = next.getNext();
> 169       return ret;
> 170     }
> {code}
> Should it be as follows?
> {code}
> ...
> 164       if (null == next) {
> 165         throw new NoSuchElementException();
> 166       }
> ...
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to