[
https://issues.apache.org/jira/browse/MNEMONIC-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047177#comment-16047177
]
ASF GitHub Bot commented on MNEMONIC-278:
-----------------------------------------
Github user bigdata-memory commented on a diff in the pull request:
https://github.com/apache/incubator-mnemonic/pull/46#discussion_r121546187
--- Diff: docker/README.md ---
@@ -34,7 +33,8 @@ For old version docker v1.10 below, Please replace ARG
with ENV and set its valu
Build from git repository
```bash
- $ docker build -t NAME[:TAG]
https://github.com/apache/incubator-mnemonic.git#:docker
+ $ docker build -t NAME[:TAG]
https://github.com/apache/incubator-mnemonic.git#:docker:docker-centos
+ $ docker build -t NAME[:TAG]
https://github.com/apache/incubator-mnemonic.git#:docker:docker-ubuntu
--- End diff --
Please note the use of letter case, using docker-Ubuntu instead of
docker-ubuntu.
Please also correct the corresponding folder name
> Re-structure the folders of docker
> ----------------------------------
>
> Key: MNEMONIC-278
> URL: https://issues.apache.org/jira/browse/MNEMONIC-278
> Project: Mnemonic
> Issue Type: Improvement
> Components: Docker
> Affects Versions: 0.8.0-incubating
> Reporter: Wang, Gang
> Assignee: Lan Lin
>
> The docker folders i.e. docker/ docker-ubuntu/ could be re-organized as
> follows to improve the structure of docker related files.
> {code}
> incubator-mnemonic
> .........|____docker/
> ...............|_____docker-CentOS/
> ............................|____Dockerfile
> ...............|_____docker-Ubuntu/
> ............................|____Dockerfile
> ...............|_____README.md
> {code}
> Please also include the docker/ in build-tools/source-assembly.xml
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
