It looks good. Only thing is that the context classloader doesn't seem to be restored, and the Property class is not required if you use the proper format for properties in the mojo.
I had actually expected to go to the newer configuration to enable the other one to be cleaner, and still fork the process. I think there is a place for all three mojos, but I'm fine with this being released as is if the above is addressed. - Brett Kaare Nilsen wrote: > Yo guys. > Have just commited a exec:java goal. please take a look at it and see > if this is about what we wanted.. > For example of config look in the src/test/projects/project2/pom.xml > > In addition : > The testcases does not run in my machine with an this error message : > > org.apache.maven.artifact.resolver.ArtifactResolutionException: Unable > to get dependency information: Unable to read the metadata file for > artifact 'commons-logging:commons-logging:jar': Error getting POM for > 'commons-logging:commons-logging' from the repository: Unsupported > Protocol: 'http': Cannot find wagon which supports the requested > protocol: http > commons-logging:commons-logging:1.0.4:pom > > And.. The LICENSE.txt is MIT license but all the files includes the > apache license in the header.. > > > > > On 10/03/06, Kaare Nilsen <[EMAIL PROTECTED]> wrote: >> On 10/03/06, Jesse McConnell <[EMAIL PROTECTED]> wrote: >>> I had put together the original maven-execute-plugin and all it did was >>> basically was make sure that the compiled classes where in the classloader >>> and then run a specified java class's main method...very straight-forward >>> and no bells and whistles.. >>> >>> I agree this ought to be another mojo and frankly I thought it was when the >>> functionality was brought over :) >>> >>> this ought to be an easy fix and if someone else doesn't do it I'll take >>> care of it later today before I get back to the axistools plugin >>> >>> kaare, was this you volunteering to patch the existing exec plugin with the >>> new mojo? >> ;).. It was not ment to be that, but hey.. it's weekend.. At least I >> can sumbit a mojo in the execplugin with the goal java.. like >> exec:java. >> where I gather all the dependencies and add them to the classloader, >> and run a spesified mainClass.. But not tonigh.. Fridays are family >> night, so if I open my laptop and start programming my wife would kill >> me ;) >> >>> jesse >>> >>> >>> On 3/10/06, Kaare Nilsen < [EMAIL PROTECTED]> wrote: >>>> You thinking og having just a wrapper around cli here like the other >>>> goal, or should we do it like in e.g. surefire with an isolated >>>> classloader containg url's to all the dependencies in the pom ? >>>> >>>> >>>> On 09/03/06, Brett Porter <[EMAIL PROTECTED] > wrote: >>>>> +0.5 >>>>> >>>>> I'm confused by the <classpath> element in the middle of the arguments, >>>>> especially in light of what the TODO says. >>>>> >>>>> If you are going to have a classpath, why not have a mojo for exec:java? >>>>> With... >>>>> >>>>> <configuration> >>>>> <options /> -> stuff before the mainClass >>>>> <systemProperties /> -> special case of above >>>>> <mainClass /> -> not required with mainJar >>>>> <mainJar /> -> java -jar ... >>>>> <classpath /> >>>>> <arguments /> -> args after the mainClass (args[]) >>>>> </configuration> >>>>> >>>>> My 2 cents. Not a blocker, but I really think the classpath thing above >>>>> is confusing. >>>>> >>>>> - Brett >>>>> >>>>> jerome lacoste wrote: >>>>>> Hi everyone, >>>>>> >>>>>> Apparently the exec-maven-plugin is referenced from a not yet >>>>>> published m2 book and needs to be available from a repository before >>>>>> the book gets out. >>>>>> >>>>>> The plugin has been available 5 weeks as snapshot and I didn't see any >>>>>> reported problems/enhancements requests since. To my knowledege the >>>>>> only Jira issue in mojo-sandbox that references exec in its >>>>>> description is >>> http://jira.codehaus.org/browse/MOJO-34, but it's not >>>>>> directly related to the plugin. >>>>>> >>>>>> So.. as there doesn't seem to be any show stopper, I would like to >>>>>> graduate the plugin from the sandbox and make a first official 1.0 >>>>>> release (skipping any form of beta). >>>>>> >>>>>> I'll open up the vote for 72h, then provide a summary >>>>>> >>>>>> +1 from me >>>>>> >>>>>> J >>>>>> >>> >>> >>> -- >>> jesse mcconnell >>> jesseDOTmcconnellATgmailDOTcom >
