On 4 Jun 07, at 3:25 PM 4 Jun 07, Jochen Wiedmann wrote:
Hi, Brett,
On 6/4/07, Brett Porter <[EMAIL PROTECTED]> wrote:
The fix for MCLIRR-2 is not really correct. This makes the @execute
phase irrelevant, and it causes clirr:clirr to fail on something like
maven-model where the sources are generated.
I think the problem is that executedProject doesn't appear to be
working under Maven 2.0.6 for reports in the site.
I won't refuse your changes, but I'd like to understand.
1.) Why do you think that executedProject should be used? When I
added some
debugging code, I found that executedProject to contain real
nonsence.
(An empty project, or something like that.)
When run as part of the lifecycle the executedProject will be empty.
If you run the individual goal then the forked lifecycle will fire
and the executedProject will be populated. I think in most cases we
should just make this transparent but we don't and that's how it
currently works. So if you want the mojo to work in a lifecycle as
well as direct invocation then you need to do something like
getProject()
{
if ( executedProject != null )
return executedProject;
else
return project;
}
2.) Why do you thunk that the existence or nonexistence of
compileSourceRoots isn't
relevant?
Thanks,
Jochen
--
Women have the ability to wind you round their little finger.
Daughters can use all of the fingers together.
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder and PMC Chair, Apache Maven
jason at sonatype dot com
----------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
