-D commandline properties no longer passed through in SystemProperties in
exec:java
-----------------------------------------------------------------------------------
Key: MEXEC-41
URL: http://jira.codehaus.org/browse/MEXEC-41
Project: Maven 2.x Exec Plugin
Issue Type: Bug
Affects Versions: 1.1-beta-1
Environment: using maven-core from the tip of the 2.0.x branch (ie,
the as-yet-unreleased 2.0.9)
Reporter: Richard van der Hoff
My patch for MNG-2848 included removing System.setProperty( name, value ) for
properties passed in with -D commandLine arguments (since the comment implied
that wasn't necessary).
Unfortunately, that means that any properties passed in with -D on the
commandline are no longer passed in as SystemProperties in exec:java.
I'd argue that it was happy coincidence that this ever worked, as plugins
shouldn't really be accessing commandline properties through the
SystemProperties, however it's far too useful a feature to drop.
I see a couple of possibilities:
1) Reinstate System.setProperty for all properties passed on the commandline.
This would be quick and reliable, but seems somehow wrong given its only
exec:java which would be making use of it.
2) Add all the properties in context.getExecutionProperties() to the
SystemProperties before running exec:java. This fits in better with the maven
API, but would mean that suddenly every property defined in the pom, plus a
load of env.foo properties for the environment, would get passed through to the
subprocess.
Any thoughts?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
