Classifiers get lost during install
-----------------------------------

                 Key: MSHITTY-30
                 URL: http://jira.codehaus.org/browse/MSHITTY-30
             Project: Maven 2.x SHITTY Plugin
          Issue Type: Bug
          Components: Install
    Affects Versions: 1.0-alpha-3
            Reporter: Dennis Homann
            Assignee: Jason Dillon


If a project has multiple attached artifacts with different classifiers (e.g. 
zip artifacts), the classifier information will get lost when the "testing" 
version is installed.

Example: A project has the following attached artifacts:
{noformat}
myproject-<version>.jar
myproject-<version>-classifier1.zip
myproject-<version>-classifier2.zip
{noformat}

The SHITTY InstallMojo will install the "testing" versions as

{noformat}
myproject-testing.jar
myproject-testing.zip
{noformat}

Both {{myproject\-<version>\-classifier1.zip}} and 
{{myproject\-<version>\-classifier2.zip}} will be copied to the same location 
{{myproject\-testing.zip}}.

I suggest the following patch:

{noformat}
Index: src/main/groovy/org/codehaus/mojo/shitty/InstallMojo.groovy
===================================================================
--- src/main/groovy/org/codehaus/mojo/shitty/InstallMojo.groovy (Revision 7345)
+++ src/main/groovy/org/codehaus/mojo/shitty/InstallMojo.groovy (Arbeitskopie)
@@ -156,12 +156,12 @@
         log.debug("Using version '$version' for artifact: $originalArtifact")

         // Clone the artifact with a new version
-        Artifact artifact = artifactFactory.createArtifact(
+        Artifact artifact = artifactFactory.createArtifactWithClassifier(
             originalArtifact.groupId,
             originalArtifact.artifactId,
             version,
-            null,
-            originalArtifact.type
+            originalArtifact.type,
+            originalArtifact.classifier
         )
{noformat}


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to