> The POM is missing a <scm> element causing the "Source Repository" report to
> point at a wrong URL.
Fixed.
> "mvn dependency:analyze" is reporting some undeclared/unused deps.
Fixed.
> The mojo's parameter "project" should probably have the "@readonly"
> annotation. Not many users will want to stuff another Maven project in there
> ;-)
Fixed.
> You could consider to initialize mojo parameters that are populated from the
> POM via "default-value" instead of "expression" [0, 1].
Fixed, but not for mainClass since we need to support setting that
directly from the command line.
> Regarding:
>>
>> FileWriter writer = new FileWriter( infoPlist );
>> velocity.getEngine().mergeTemplate( dictionaryFile, "utf-8",
>> velocityContext, writer );
>
> These lines are subject to encoding issues [2]:
Fixed by adding an EncodingDetector that peeks at the first characters
of the file using utf-8 and extracts the encoding from any <?xml
encoding=".."?> occurrances.
This encoding is used when reading the template and when writing the
result to file.
> In src/site/examples/custom-dictionary.apt there are some typos in the
> sentence
Fixed.
> Finally, consider to add <version> elements to the POM snippets shown in the
> docs to teach users the best practice of locking down the plugin version.
Fixed.
> Apart from these knick knacks, amazingly comprehensive documentation, good
> job!
You're not so bad yourself either :-) Excellent QA work, thanks a lot!
Eirik.
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
